-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed wrong rotation for flipped images in auto_rotate filter #639
Conversation
can you add a test case? |
I was able to setup my test environment but now I'm having issues faking the metadata object. $metaData = $this->getMock('Metadata\MetadataInterface');
$metaData
->expects($this->once())
->method('offsetGet')
->willReturn("1")
;
$metaData->offsetGet();
// Call to undefined method Mock_MetadataInterface_7f3f507c::offsetGet() Am I missing something obvious? I don't even know where |
this interface is part of the "jms/metadata" composer package I guess .. but what makes you believe you need to mock this interface for a test? |
…pImagineBundle into auto_rotate_flip Conflicts: Tests/Imagine/Filter/Loader/AutoRotateFilterLoaderTest.php
The autorotate needs to get the metadata from the image to know the rotation. So I want to mock it, to avoid having to provide real pictures. I found the info on https://imagine.readthedocs.org/en/latest/usage/metadata.html. The |
I added the test cases and followed StyleCI recommendations. |
the style issues were already fixed in master .. it would be best if you start a new branch from current master and cherry pick your changes into there. |
…/or flip the image - Task: refactored the tests to more easily see which tests fail
Actually I only fixed the StyleCI issues for the files I modified. |
The original code was not rotating (nor flipping) flipped images.
The code has been tested using those images https://github.com/recurser/exif-orientation-examples